pin importlib_resources to 5 series #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 6.0.0 removed various deprecated functions but these are still used by sphinx-contrib-towncrier
Codecov Report
@@ Coverage Diff @@
## master #5270 +/- ##
==========================================
+ Coverage 67.50% 67.53% +0.03%
==========================================
Files 359 359
Lines 29882 29882
==========================================
+ Hits 20171 20181 +10
+ Misses 9711 9701 -10 |
einsmein
approved these changes
Jul 17, 2023
jenshnielsen
added a commit
that referenced
this pull request
Jul 19, 2023
pin importlib_resources to 5 series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 6.0.0 removed various deprecated functions but these are still used by towncrier which we use to build the docs.
This is fixed in twisted/towncrier#529 but not yet in a release
Also remove env marker from importlib_metadata. This file is only used to constrain requirements so there is no need
to use the env marker here. That is done in pyproject.toml and having it here prevents dependabot from bumping the version