Add adjust_parameter_validator function to IVVI instrument #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolution of dac's into account for validator range.
|
@peendebak @eendebakpt updates on this ? From my side it can be merged. |
|
@CJvanDiepen @Unga The PR looks good and is fully backwards compatible.:dancer: |
giulioungaretti
pushed a commit
that referenced
this pull request
May 5, 2017
Author: CJvanDiepen <CJvanDiepen@users.noreply.github.com>
driver: Add adjust_parameter_validator function to IVVI (#529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dac's of the IVVI have a finite resolution. If the validator range min and max values are not values the dac's can actually have, then it can occur that a set command results in the dac's going to a value just outside the validator range. Adjusting the validators with this function prevents that.
Fixes #301.
Changes proposed in this pull request:
adjust_parameter_validatorfunction to IVVI instrument.@giulioungaretti @peendebak