Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasaver_builder and dond_core #5294

Merged
merged 45 commits into from Aug 11, 2023

Conversation

samantha-ho
Copy link
Contributor

datasaver_builder and dond_core are intermediate abstractions designed to be used between the low level Measurement context and the high level doNd functions. They allow for greater flexibility in measurement than doNd without requiring parameter registration and explicit datasaver calls.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #5294 (4ae56f1) into master (9d95828) will increase coverage by 0.06%.
The diff coverage is 98.05%.

@@            Coverage Diff             @@
##           master    #5294      +/-   ##
==========================================
+ Coverage   67.53%   67.60%   +0.06%     
==========================================
  Files         359      360       +1     
  Lines       29889    29987      +98     
==========================================
+ Hits        20187    20273      +86     
- Misses       9702     9714      +12     

@samantha-ho
Copy link
Contributor Author

Last thing to do is replace the example with an actual tutorial on using the datasaver_builder.

@samantha-ho samantha-ho marked this pull request as ready for review August 8, 2023 20:48
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry, apparently i reviewed last week but didn't submit these comments; apologies if some of them are obsolete; i'll do another review of the latest changes tomorrow)

qcodes/dataset/measurement_extensions.py Outdated Show resolved Hide resolved
qcodes/dataset/measurement_extensions.py Outdated Show resolved Hide resolved
docs/changes/newsfragments/5294.improved Outdated Show resolved Hide resolved
qcodes/dataset/measurement_extensions.py Outdated Show resolved Hide resolved
qcodes/dataset/measurement_extensions.py Outdated Show resolved Hide resolved
qcodes/dataset/measurement_extensions.py Outdated Show resolved Hide resolved
qcodes/dataset/measurement_extensions.py Show resolved Hide resolved
docs/examples/DataSet/Datasaver_Builder.ipynb Outdated Show resolved Hide resolved
@samantha-ho samantha-ho added this pull request to the merge queue Aug 11, 2023
Merged via the queue into microsoft:master with commit 5c1fd24 Aug 11, 2023
14 of 15 checks passed
@samantha-ho samantha-ho deleted the samanthaho/complex_context branch August 11, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants