New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datasaver_builder and dond_core #5294
Add datasaver_builder and dond_core #5294
Conversation
Remove comment and type ignore
Add tests for Callables, TogetherSweeps, and Groups
for more information, see https://pre-commit.ci
…tha-ho/Qcodes into samanthaho/complex_context
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #5294 +/- ##
==========================================
+ Coverage 67.53% 67.60% +0.06%
==========================================
Files 359 360 +1
Lines 29889 29987 +98
==========================================
+ Hits 20187 20273 +86
- Misses 9702 9714 +12 |
Last thing to do is replace the example with an actual tutorial on using the datasaver_builder. |
Add new extensions to __init__
for more information, see https://pre-commit.ci
…tha-ho/Qcodes into samanthaho/complex_context
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sorry, apparently i reviewed last week but didn't submit these comments; apologies if some of them are obsolete; i'll do another review of the latest changes tomorrow)
Update docstrings with new args and behaviors
datasaver_builder and dond_core are intermediate abstractions designed to be used between the low level Measurement context and the high level doNd functions. They allow for greater flexibility in measurement than doNd without requiring parameter registration and explicit datasaver calls.