Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxford Triton: Add control of pumps and temperature channels #5316

Conversation

FredWolff
Copy link
Contributor

@FredWolff FredWolff commented Aug 14, 2023

This pull request adds the following parameters to the driver: pid_p, pid_i, pid_d, turb1_speed, turb1_state, comp_state and Tx_state where x represents the temperature channel id and runs from 1 to 17. The pid-parameters set and get the pid-values for the temperature controller. turb1_speed gets the speed of the turbo in Hz. The _state parameters get and set whether the pumps and temperature channels are on or off.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #5316 (1723b01) into master (5c1fd24) will decrease coverage by 0.04%.
Report is 33 commits behind head on master.
The diff coverage is 5.98%.

@@            Coverage Diff             @@
##           master    #5316      +/-   ##
==========================================
- Coverage   67.63%   67.59%   -0.04%     
==========================================
  Files         360      360              
  Lines       29987    30012      +25     
==========================================
+ Hits        20283    20288       +5     
- Misses       9704     9724      +20     

@FredWolff FredWolff marked this pull request as ready for review August 14, 2023 14:49
@jenshnielsen jenshnielsen changed the title Add control of pumps and temperature channels Oxford Triton: Add control of pumps and temperature channels Aug 23, 2023
qcodes/instrument_drivers/oxford/triton.py Outdated Show resolved Hide resolved
@jenshnielsen jenshnielsen added this pull request to the merge queue Aug 24, 2023
Merged via the queue into microsoft:master with commit 761f244 Aug 24, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants