Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add register_name to register parameters by in datasets #5381

Merged
merged 23 commits into from
Oct 6, 2023
Merged

Add register_name to register parameters by in datasets #5381

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d30f70c
Initial implementation
samantha-ho Sep 19, 2023
6f64db9
Fix formatting issues
samantha-ho Sep 20, 2023
431ae5a
Updating other places where name/full_name were assumed
samantha-ho Sep 20, 2023
61160b1
Add integration tests
samantha-ho Sep 21, 2023
acfe156
Add docstring
samantha-ho Oct 5, 2023
1c9f482
Rename test parameters
samantha-ho Oct 5, 2023
ddce884
Add str_or_register to public API
samantha-ho Oct 5, 2023
7b080c2
Expand Tests and add str_or_register_name to `unregister`
samantha-ho Oct 5, 2023
6b2c8b0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 5, 2023
39a5fee
Add example notebook
samantha-ho Oct 5, 2023
f12a200
Add Changelog file
samantha-ho Oct 5, 2023
e06c11c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 5, 2023
13d02c9
Merge branch 'master' into samanthaho/register_names
samantha-ho Oct 5, 2023
60cb958
Fix pre-commit errors
samantha-ho Oct 5, 2023
db6462f
Expand error message to refer to register_name
samantha-ho Oct 5, 2023
5320c0b
Keep str_or_register_name `private`
samantha-ho Oct 6, 2023
6ecbcda
Apply docstring suggestions from code review
samantha-ho Oct 6, 2023
98f3388
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2023
88aa0dc
Remove missed reference to str_or_register_name in _init__ all
samantha-ho Oct 6, 2023
ea36aef
Merge branch 'samanthaho/register_names' of https://github.com/samant…
samantha-ho Oct 6, 2023
bbbdc3c
Reformat for Darker
samantha-ho Oct 6, 2023
c703b81
More Reformatting for Darker
samantha-ho Oct 6, 2023
862d3ea
Darkening
samantha-ho Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view