Move tests outside of src layout #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
src_layout_move_tests
branch
from
93dfdc5
to
9dd4234
Compare
jenshnielsen
force-pushed
the
src_layout_move_tests
branch
from
9dd4234
to
089fac2
Compare
Codecov Report
@@ Coverage Diff @@
## main #5452 +/- ##
==========================================
- Coverage 67.33% 66.31% -1.03%
==========================================
Files 342 354 +12
Lines 30029 30951 +922
==========================================
+ Hits 20221 20526 +305
- Misses 9808 10425 +617 |
jenshnielsen
force-pushed
the
src_layout_move_tests
branch
3 times, most recently
from
7070aaa
to
535a06b
Compare
jenshnielsen
assigned jenshnielsen, einsmein, samantha-ho and trevormorgan and unassigned jenshnielsen, einsmein, samantha-ho and trevormorgan
jenshnielsen
requested review from
astafan8,
einsmein,
samantha-ho and
trevormorgan
astafan8
approved these changes
Nov 9, 2023
jenshnielsen
force-pushed
the
src_layout_move_tests
branch
from
1aee723
to
fbcd666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it cleaner what it tests and what is being tested.
There seems to be a bug in codecov / coverage where qcodes.tests is now counted despite being excluded.