Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lakeshore 335 Output: Add parameter mapping for input=None #5520

Merged

Conversation

jbeckerwsi
Copy link
Contributor

@jbeckerwsi jbeckerwsi commented Nov 14, 2023

According to the manual (https://www.lakeshore.com/docs/default-source/product-downloads/335_manual.pdf?sfvrsn=9f5c5b7f_7) , page 121:

input Specifies which input to use for control: 0 = None, 1 = A, 2 = B

Here, we add the parameter mapping for the value 0.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #5520 (b8061e2) into main (7f114bf) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5520   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files         354      354           
  Lines       30953    30954    +1     
=======================================
+ Hits        20530    20531    +1     
  Misses      10423    10423           

@jenshnielsen
Copy link
Collaborator

@jbeckerwsi thanks. Would you mind adding a news fragment for the change?

@jenshnielsen jenshnielsen added this pull request to the merge queue Nov 15, 2023
Merged via the queue into microsoft:main with commit 62b3498 Nov 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants