Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn Monitor thread into daemon #5565

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Turn Monitor thread into daemon #5565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e02354
Turn Monitor thread into daemon
michaelc12qe Nov 29, 2023
f2d8629
Add changelog entry for daemonized monitor
michaelc12qe Nov 30, 2023
4a371eb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changes/newsfragments/improved.5565
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
qcodes.Monitor now runs as a daemon thread, resolving issues with closing python or ipython with a running qcodes.Monitor.
2 changes: 1 addition & 1 deletion src/qcodes/monitor/monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def __init__(
use_root_instrument: Defines if parameters are grouped according to
parameter.root_instrument or parameter.instrument
"""
super().__init__()
super().__init__(daemon=True)

# Check that all values are valid parameters
for parameter in parameters:
Expand Down