Driver improvement: QDac sync #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to assign sync outputs for voltage ramps.
jenshnielsen
reviewed
Apr 4, 2017
| if chan in [syn[0] for syn in self._syncoutputs]: | ||
| syncing = True | ||
| sync = [syn[1] for syn in self._syncoutputs if syn[0] == chan][0] | ||
| self.write('syn {} {} 0 {}'.format(sync, fg, 10)) |
There was a problem hiding this comment.
10 ms sync pulse duration.
There was a problem hiding this comment.
Ok, I suggest making a it variable called sync duration to make this explicit
| @@ -438,6 +492,9 @@ def _rampvoltage(self, chan, fg, setvoltage, ramptime): | |||
| self.write(funmssg) | |||
| self.parameters['ch{:02}_v'.format(chan)]._save_val(setvoltage) | |||
|
|
|||
There was a problem hiding this comment.
What happens if you interrupt during this before sync is reset?
There was a problem hiding this comment.
Then your sync is still assigned.
There was a problem hiding this comment.
We've agreed that this is not an issue, due to syncs being overriden by subsequent calls to _ramp_voltage.
| # interrupted | ||
| v_start = self.parameters['ch{:02}_v'.format(chan)].get() | ||
| log.warning('Cancelled a ramp with a ramptime of ' | ||
| '{} s'.format(ramptime)) |
There was a problem hiding this comment.
Make it more explicit that no voltage change is performed
jenshnielsen
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sync pulses available
Changes proposed in this pull request:
getcommandTo come:
@jenshnielsen