Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loading from netcdf lazy using load_by_guid etc. #5711

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Make loading from netcdf lazy using load_by_guid etc. #5711

merged 5 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. add test that load_by_guid etc is lazy when loading from netcdf

    @jenshnielsen
    jenshnielsen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    cdf2df3 View commit details
    Browse the repository at this point in the history

  2. lazy load data from netcdf when loading using load_by_guid etc

    @jenshnielsen
    jenshnielsen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    83a3bd4 View commit details
    Browse the repository at this point in the history

  3. Add changelog for 5711

    @jenshnielsen
    jenshnielsen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    40282d1 View commit details
    Browse the repository at this point in the history

  4. work around mypy type narrowing limitations

    @jenshnielsen
    jenshnielsen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0d0ea2c View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
    @jenshnielsen @astafan8
    jenshnielsen and astafan8 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9ad966e View commit details
    Browse the repository at this point in the history