Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pyright with standard checks #5721

Merged
merged 21 commits into from
Mar 4, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 3, 2024

This basically means checking that overrides are compatible with the base class

Breaking changes

  • The first argument to NumpyJSONEncoder.default is not o not obj. I don't expect this to be called directly. Only public so it can be passed to a json encoder.
  • Unused arguments to QDac connect_messsage have changed. Not an issue since they are unused.
  • Keysight N52XX and Infiniium Unused arguments to stub setpoints and unit methods have changed from val to setpoints / unit. Not an issue since these are unused stubs.
  • Alazar DemodulationAcquisitionController handle_data argument changed from data to buffer. Probably unlikely to be called as a kwarg.
  • InstrumentModule/Channel obj -> value in Sequence/MutableSequence methods. IMHO unlikely to be called by arg since these are simple single argument methods. Left this one out for now and ignored the warnings
  • Private: but could still be used in other drivers parameter._wrap_set and _wrap_get no longer takes an argument.

@jenshnielsen jenshnielsen requested a review from a team as a code owner February 3, 2024 10:15
@jenshnielsen jenshnielsen marked this pull request as draft February 3, 2024 10:16
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (7e61922) 67.55% compared to head (5ebbaaa) 67.54%.

Files Patch % Lines
src/qcodes/tests/dataset/conftest.py 0.00% 9 Missing ⚠️
..._drivers/AlazarTech/ATS_acquisition_controllers.py 0.00% 1 Missing ⚠️
src/qcodes/instrument_drivers/Keysight/KtM960x.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5721      +/-   ##
==========================================
- Coverage   67.55%   67.54%   -0.02%     
==========================================
  Files         348      348              
  Lines       30246    30251       +5     
==========================================
- Hits        20434    20433       -1     
- Misses       9812     9818       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen force-pushed the pyright_standard branch 2 times, most recently from d8bf81f to 895f1b7 Compare February 28, 2024 09:19
@jenshnielsen jenshnielsen added this pull request to the merge queue Mar 4, 2024
Merged via the queue into microsoft:main with commit 2943def Mar 4, 2024
19 checks passed
@jenshnielsen jenshnielsen deleted the pyright_standard branch March 4, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants