only use 10 digits when testing field vectors #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully avoid corner cases in test_triangle_inequality where one of the vectors is very small but none zero since the values are anyway limited to the resolution of the instruments there is little point in supporting more than 10 digits
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5741 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 348 348
Lines 30251 30251
=======================================
Hits 20437 20437
Misses 9814 9814 ☔ View full report in Codecov by Sentry. |
jenshnielsen
changed the title
astafan8
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully avoid corner cases in test_triangle_inequality where one of the vectors is very small but none zero
since the values are anyway limited to the resolution of the instruments there is little point in supporting more than 10 digits
Closes #4425