-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple indexed attribute access in station files #5887
Simple indexed attribute access in station files #5887
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5887 +/- ##
==========================================
+ Coverage 67.45% 67.46% +0.01%
==========================================
Files 348 348
Lines 30138 30157 +19
==========================================
+ Hits 20329 20345 +16
- Misses 9809 9812 +3 ☔ View full report in Codecov by Sentry. |
Would be nice with an example of this in the station notebook here https://github.com/microsoft/Qcodes/blob/main/docs/examples/Station.ipynb but I think that is optional. Other than that the only remaining issue is IMHO the precommit hooks |
@hp-peti BTW unless there are conflicts you do not need to worry about merging main into the feature branch. Github actions will take care of making sure that it is tested against main before merging |
need workflow approval
I don't have the courage to modify that notebook; the example station.yaml is an image file i don't want to mess with.
auto organized |
bc08cb7
to
3e1f937
Compare
need another workflow approval. not sure what's happening on the merge queue. |
Some drivers (see zurich-instruments) only expose parameters through an interface which needs indexing in addition to attribute access. This patch enables access to those parameters in the station yaml file.
3e1f937
to
b701a1c
Compare
pinging again, i need workflow approval and please put back in merge queue. thanks in advance |
thanks everyone |
Some drivers (see zurich-instruments) only expose parameters through an interface which needs indexing in addition to attribute access. This patch enables access to those parameters in the station yaml file.