Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple indexed attribute access in station files #5887

Merged

Conversation

hp-peti
Copy link
Contributor

@hp-peti hp-peti commented Mar 25, 2024

Some drivers (see zurich-instruments) only expose parameters through an interface which needs indexing in addition to attribute access. This patch enables access to those parameters in the station yaml file.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (5a57e73) to head (b701a1c).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5887      +/-   ##
==========================================
+ Coverage   67.45%   67.46%   +0.01%     
==========================================
  Files         348      348              
  Lines       30138    30157      +19     
==========================================
+ Hits        20329    20345      +16     
- Misses       9809     9812       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen
Copy link
Collaborator

jenshnielsen commented Apr 5, 2024

Would be nice with an example of this in the station notebook here https://github.com/microsoft/Qcodes/blob/main/docs/examples/Station.ipynb but I think that is optional.

Other than that the only remaining issue is IMHO the precommit hooks

@jenshnielsen
Copy link
Collaborator

@hp-peti BTW unless there are conflicts you do not need to worry about merging main into the feature branch. Github actions will take care of making sure that it is tested against main before merging

@hp-peti
Copy link
Contributor Author

hp-peti commented Apr 5, 2024

need workflow approval

Would be nice with an example of this in the station notebook here https://github.com/microsoft/Qcodes/blob/main/docs/examples/Station.ipynb but I think that is optional.

I don't have the courage to modify that notebook; the example station.yaml is an image file i don't want to mess with.

Other than that the only remaining issue is IMHO the precommit hooks

auto organized utils/__init__.py to fix issue

@jenshnielsen jenshnielsen added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@hp-peti hp-peti force-pushed the hp-peti/attribute-indexing-in-station-files branch 2 times, most recently from bc08cb7 to 3e1f937 Compare April 5, 2024 15:36
@hp-peti
Copy link
Contributor Author

hp-peti commented Apr 5, 2024

need another workflow approval.

not sure what's happening on the merge queue.
@jenshnielsen @astafan8 let me know there is anything i need to do
thanks in adv

Some drivers (see zurich-instruments) only expose parameters through an interface which needs indexing in addition to attribute access. This patch enables access to those parameters in the station yaml file.
@hp-peti hp-peti force-pushed the hp-peti/attribute-indexing-in-station-files branch from 3e1f937 to b701a1c Compare April 5, 2024 17:42
@hp-peti
Copy link
Contributor Author

hp-peti commented Apr 9, 2024

pinging again, i need workflow approval and please put back in merge queue. thanks in advance

@astafan8 astafan8 enabled auto-merge April 11, 2024 07:40
@astafan8 astafan8 added this pull request to the merge queue Apr 11, 2024
Merged via the queue into microsoft:main with commit 89615e0 Apr 11, 2024
19 checks passed
@hp-peti hp-peti deleted the hp-peti/attribute-indexing-in-station-files branch April 11, 2024 09:28
@hp-peti
Copy link
Contributor Author

hp-peti commented Apr 11, 2024

thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants