Feature: adding new driver for Agilent signal generator E8267C #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
reviewed
May 5, 2017
| max_value=20e-9)) | ||
| self.add_parameter(name='phase', | ||
| label='Phase', | ||
| unit='rad', |
There was a problem hiding this comment.
looks like this is degrees?
|
|
||
| # functions to convert between rad and deg | ||
|
|
||
| def deg_to_rad(self, angle_deg): |
There was a problem hiding this comment.
These functions are in numpy https://docs.scipy.org/doc/numpy/reference/generated/numpy.deg2rad.html perhaps use them from there
There was a problem hiding this comment.
definitely use numpy !
|
@jenshnielsen @giulioungaretti fixed the numpy functions |
jenshnielsen
approved these changes
May 10, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
May 10, 2017
Author: euchas <adomas.valantinas@gmail.com>
driver: add Agilent signal generator E8267C (#597)
giulioungaretti
pushed a commit
that referenced
this pull request
May 10, 2017
Author: euchas <adomas.valantinas@gmail.com>
driver: add Agilent signal generator E8267C (#597)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added all basic commands.
why no one likes 馃拑 :(
@giulioungaretti @jenshnielsen