Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate opencensus integration #5991

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Apr 22, 2024

And remove default install of opencensus and opencensus azure integration.

Note that this does not yet remove opencensus from requirements.txt. This will happen once a release of qcodes with these changes is out. This is due to the "circular" dependencies between qcodes[test], qcodes-loop, and qcodes.

TODO

  • Breaking change notice

@jenshnielsen jenshnielsen requested a review from a team as a code owner April 22, 2024 07:05
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.40%. Comparing base (1f6b4fa) to head (d4d8eee).

Files Patch % Lines
src/qcodes/logger/logger.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5991   +/-   ##
=======================================
  Coverage   67.40%   67.40%           
=======================================
  Files         349      349           
  Lines       30194    30199    +5     
=======================================
+ Hits        20352    20356    +4     
- Misses       9842     9843    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/qcodes/logger/logger.py Outdated Show resolved Hide resolved
jenshnielsen and others added 2 commits April 22, 2024 17:11
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
@jenshnielsen jenshnielsen added this pull request to the merge queue Apr 22, 2024
Merged via the queue into microsoft:main with commit 0ee413d Apr 22, 2024
18 of 19 checks passed
@jenshnielsen jenshnielsen deleted the opencensus_deprecate branch April 22, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants