Validator for callables as parameter #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcodes/utils/validators.py
Outdated
| pass | ||
|
|
||
| def validate(self, value, context=''): | ||
| if not hasattr(value, '__call__'): |
There was a problem hiding this comment.
Any reason to not use if not callable(value)
There was a problem hiding this comment.
Good suggestion, I'll make the change.
|
Looks good to me apart from a single inline comment |
|
@jenshnielsen , I addressed your comments, let me know what you think. |
jenshnielsen
approved these changes
Jun 21, 2017
|
@AdriaanRol Great looks good to me |
giulioungaretti
pushed a commit
that referenced
this pull request
Jun 21, 2017
Author: Adriaan <AdriaanRol@users.noreply.github.com>
Validator for callables as parameter (#650)
Dominik-Vogel
pushed a commit
to Dominik-Vogel/Qcodes
that referenced
this pull request
Aug 9, 2017
* Validator for callables as parameter * Addressed comment by jenshnielsen
peendebak
pushed a commit
to VandersypenQutech/Qcodes
that referenced
this pull request
Aug 11, 2017
* Validator for callables as parameter * Addressed comment by jenshnielsen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
@giulioungaretti