Correctly count number of actions when updating combined measurements #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenshnielsen that seems to work for me! |
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 18, 2017
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Correctly count number of actions when updating combined measurements (#670)
Dominik-Vogel
pushed a commit
to Dominik-Vogel/Qcodes
that referenced
this pull request
Aug 9, 2017
…microsoft#670) * Correctly count number of actions when updateting combined measurements * add tests for loops over combined parameters * Add hypothesis to test combined aggregator * combined loop teardown * simplify tests * remove unused print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #669
The issue is that the base parameters within the combined parameter were being looked up from an index that always starts at 1. This is only true if there is only one parameter/task being measured/executed within the loop. This corrects the counting