better warning handling for slack class #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peendebak Haha I'm starting to regret my comment on catching a specific error, I didn't realize that there were several possible errors. Looks good though! |
jenshnielsen
approved these changes
Aug 1, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Aug 1, 2017
Author: peendebak <P.T.eendebak@tudelft.nl>
better warning handling (#681)
giulioungaretti
pushed a commit
that referenced
this pull request
Aug 1, 2017
Author: peendebak <P.T.eendebak@tudelft.nl>
better warning handling (#681)
Dominik-Vogel
pushed a commit
to Dominik-Vogel/Qcodes
that referenced
this pull request
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jenshnielsen @nulinspiratie
Changes proposed in this pull request: