Speedup qdac snapshot #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulioungaretti
pushed a commit
that referenced
this pull request
Aug 3, 2017
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Speedup qdac snapshot (#686)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly speeds up the qdac snapshotting such as when adding it to a station. This is done by using _get_status to read parameters at once rather than one by one.
My benchmark shows
Creating a station with a QDac. Before 30 s, with this change 0.5 s without updating currents.
Updating currents adds about another 11 seconds both to the instrument creation and snapshot