Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add driver for Oxford Instruments ILM 200 Helium Level Meter #706

Merged
merged 7 commits into from
Aug 21, 2017

Conversation

peendebak
Copy link
Contributor

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few very minor comments, looks good otherwise

self.visa_handle.session, bytes_in_buffer)
# cannot be done on same line for some reason
mes = str(mes[0].decode())
# if mes[1] != 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete ?

elif rate == 1:
self.set_to_fast()
self.set_remote_status(3)
print(self._do_get_rate())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to log?

None

Output:
None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this returns the status?

# 01 : "Not Filling (Level < FULL, Level > FILL)",
# 10 : "Filling (Level < FULL, Level > FILL)",
# 11 : "Start Filling (Level < FILL)"
# }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is commented out and not implemented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenshnielsen Not sure why this is here. Probably left for implementation later on.

@jenshnielsen jenshnielsen merged commit 2a4a9dc into microsoft:master Aug 21, 2017
giulioungaretti pushed a commit that referenced this pull request Aug 21, 2017
Author: peendebak <P.T.eendebak@tudelft.nl>

    add driver for Oxford Instruments ILM 200 Helium Level Meter (#706)
giulioungaretti pushed a commit that referenced this pull request Aug 21, 2017
Author: peendebak <P.T.eendebak@tudelft.nl>

    add driver for Oxford Instruments ILM 200 Helium Level Meter (#706)
giulioungaretti pushed a commit that referenced this pull request Aug 21, 2017
Author: peendebak <P.T.eendebak@tudelft.nl>

    add driver for Oxford Instruments ILM 200 Helium Level Meter (#706)
@eendebakpt eendebakpt deleted the driver/ILM200 branch November 12, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants