Add instrument driver for oxford kelvinox. #707
Conversation
| set_cmd=self._set_still_power) | ||
| self.add_parameter('sorb_temp', | ||
| unit='K', | ||
| get_cmd=self._get_still_power, |
There was a problem hiding this comment.
This looks like the wrong cmd, same below for the set cmd
| @@ -0,0 +1,534 @@ | |||
| # OxfordInstruments_Kelvinox_IGH.py class, to perform the communication between the Wrapper and the device | |||
There was a problem hiding this comment.
OxfordInstruments_Kelvinox_IGH.py to either OxfordInstruments_Kelvinox_IGH or kelvinox.py
| separators so we accept them here as well. | ||
|
|
||
| Returns: | ||
| A dict containing vendor, model, serial, and firmware. |
There was a problem hiding this comment.
This produces a warning in the docs build
/home/travis/build/QCoDeS/Qcodes/qcodes/instrument_drivers/oxford/kelvinox.py:docstring of qcodes.instrument_drivers.oxford.kelvinox.OxfordInstruments_Kelvinox_IGH.get_idn:1: WARNING: Inline emphasis start-string without end-string.
It's better to write it as `*IDN?` to escape the *
| self.add_parameter('V12A_valve', | ||
| unit='%', | ||
| get_cmd=self._get_V6_valve, | ||
| set_cmd=self._set_V6_valve) |
| """ | ||
| idparts = ['Oxford Instruments', 'Kelvinox IGH', None, None] | ||
|
|
||
| return dict(zip(('vendor', 'model', 'serial', 'firmware'), idparts)) |
There was a problem hiding this comment.
There is no good way to get the firmware/serial number?
| self.remote() | ||
| log.info('Set still and sorb status') | ||
| self._execute(status) | ||
| self.local() |
There was a problem hiding this comment.
What happens if it was in remote mode before executing this command?
There was a problem hiding this comment.
This is the way it was operated before and we don't have a reason to change it, so I think it is best to leave it like it is.
|
@jenshnielsen Please take another look! If you are happy with it then I am too ;) |
Add instrument driver for Oxford Kelvinox IGH.
Changes proposed in this pull request:
Add instrument driver
@jenshnielsen