Smarter way of speeding up qdac #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both the new and old way has the same speed up from 32 to 16 ms
WilliamHPNielsen
suggested changes
Sep 14, 2017
| commands are concatenated by `;` we count the number of concatenated | ||
| commands as count(';') + 1 e.g. 'wav 1 1 1 0;fun 2 1 100 1 1' is two | ||
| commands. Note that only the response of the last command will be | ||
| available in `_write_response` | ||
|
|
||
| TODO (WilliamHPNielsen): add automatic de-concatenation of commands. |
There was a problem hiding this comment.
This PR just does that: it adds automatic de-concatenation (or at least something equivalent). This TODO should thus be removed.
WilliamHPNielsen
approved these changes
Sep 14, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Sep 14, 2017
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Smarter way of speeding up qdac (#737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @WilliamHPNielsen
Rather than disabling the second write this concatenates the commands and counts the numbers
of reads to perform afterwards.
Both the new and old way has the same speedup from 32 to 16 ms for a single set command