Ivvi triggers #739
Merged
Ivvi triggers #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) added a mock IP module to mock IP instruments 3) added a debug module to debug the AMI430 instrument
…rdinates. Work in progress
…cylindrical coodinates. By keeping a prepresnetation of the vector in all three systems, there is less risk of loss of information so that e.g. the field strength can be ramped up given previous supplied phi and theta. The spherical and cylindrical tests seem to work.
2) Made proper tests
2) Made proper tests
…uments 2) Made test to verify that the correct error is raised if we intentionally exceed the field limits
… Tests to verify this are also included.
…e mocking mechanism
…e mocking mechanism
…rdinates. Added tests to verify if we can get spherical coordinates. Also, when getting single field values, return a single float instead of an array of length one
2) Added test to verify that the correct warnings are raised if we change the default maximum ramp rate 3) Added test to verify that an error is raised if the ramp rate larger then the maximum
…pep8 conventions. Will do that tomorrow
added 9 commits
September 4, 2017 17:12
…this driver but a lot of work still needs to be done.
|
Does it make sense that a trigger is a parameter? Is this not more like a |
|
I guess that makes sense. I will fix this |
WilliamHPNielsen
approved these changes
Sep 15, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Sep 15, 2017
Author: sohail chatoor <schatoor@gmail.com>
Ivvi triggers (#739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a parameter on the QUTech IVVI driver that sends a trigger.