Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZNB don't snapshot traces #758

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

jenshnielsen
Copy link
Collaborator

They are slow and may not even function correctly if the trigger is not set and there is no point of snapshotting array parameters

They are slow and may not even function
:
@jenshnielsen
Copy link
Collaborator Author

@WilliamHPNielsen

@AdriaanRol
Copy link
Contributor

@jenshnielsen , I feel that this is a problem that is bound to occur more frequently. Rather than overwritting the snapshot method, would it not be better to add this as a property of the parameter that is set through the add_parameter method. Something like include_in_snapshot=True/False ?

@jenshnielsen
Copy link
Collaborator Author

Perhaps, but that API does not exist and this one does because of special handling in https://github.com/QCoDeS/Qcodes/blob/master/qcodes/instrument_drivers/QDev/QDac_channels.py#L107 that cannot be done with a bool as the point is to intersept the snapshot and call an alternative method the bulk updates all the parameters in one instrument call.

I will prefer not touch the parameters until #600 lands. Honestly I think we will get a long way by excluding Array and Multiparameters per default there is almost never any good reason to snapshot those.

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it should be.

@WilliamHPNielsen WilliamHPNielsen merged commit a6d4359 into microsoft:master Sep 25, 2017
@jenshnielsen jenshnielsen deleted the znb_fix_snapshot branch September 25, 2017 11:49
@jenshnielsen
Copy link
Collaborator Author

I added #759 to remind us to improve this in general

giulioungaretti pushed a commit that referenced this pull request Sep 25, 2017
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    ZNB don't snapshot traces (#758)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants