Driver/awg70000Aseries #761
Conversation
|
@WilliamHPNielsen Should I review this or do you want to wait till there is time to fix the issues? |
|
@jenshnielsen Let's wait until we actually have a unit to play with. |
the clock parameter 'sample_rate' needs a custom validator based on the clock source
… into driver/AWG70000A
|
@core this baby is ready for a review. |
| unit='V', | ||
| get_parser=lambda s: 2*10**((float(s)-10)/20), | ||
| set_parser=lambda V: 10 + 20 * np.log10(V/2), | ||
| vals=vals.Numbers(0.250, 0.500)) |
There was a problem hiding this comment.
How about using [SOURce[n]]:VOLTage[:LEVel][:IMMediate][:AMPLitude] as Carl suggested
There was a problem hiding this comment.
Yes, that seems more straightforward and less errorprone. I couldn't find that command in the manual, but I'll test is this afternoon.
| event_jumps: List[int], | ||
| event_jump_to: List[int], | ||
| go_to: List[int], | ||
| wfm_names: List[List[str]], |
There was a problem hiding this comment.
Are these modified in place otherwise I would in general suggest using Sequence see http://mypy.readthedocs.io/en/stable/common_issues.html#invariance-vs-covariance
There was a problem hiding this comment.
I'm not sure I understand the docs... The above code will fail if I pass something which is a list of a subclass of int because mypy considers List to be invariant? But immutable containers like Sequence are covariant. Is this why Sequence is preferred?
If so, I would say that it doesn't seem like such a big issue here, since we rarely subclass int, but I could be overlooking something crucial.
There was a problem hiding this comment.
So in general Sequence is preferable just to tell the user that it's imitable. The
above would in principle be wrong if you pass a tuple as go_to
| event_jumps: List[int], | ||
| event_jump_to: List[int], | ||
| go_to: List[int], | ||
| wfms: List[List[bytes]], |
… into driver/AWG70000A
Author: William H.P. Nielsen <whpn@mailbox.org>
Driver/awg70000Aseries (#761)
Add a driver for the Tektronix 70000A series AWG.
Still very unfinished.
Changes proposed in this pull request:
Done so far:
.wfmxfiles and transfer and load them.seqxformatStill pending:
.seqxformat ( I guess we have that down now)Due to time constraints, the handling of the
.seqxfiles is not well done. Two bugs that I know of:.seqxfile isinvalid if only one channel is specifiedcannot reproduce.seqxfile isinvalid if more than 20 waveforms are in it (at least if they have 100k points)that was a bug on our side that has been fixedAnd one thing that should be optimised is that the
.seqxfile is stored to disk locally upon creation, this has been fixed now.UPDATE: The
.seqxfile format is reasonably well understood now, thanks to support from Tektronix and more time spent staring at our code.@jenshnielsen