driver/Keysight Infiniium oscilloscope (as e.g. MSOS104A) #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamHPNielsen
changed the title
| # | ||
| self.shape = (npts,) | ||
| self.set_sweep(start, stop, npts) | ||
| #TODO: fix above set when any of the above things change |
There was a problem hiding this comment.
due to limitations in the dataset this cannot be set in the get command as the setpoints have already been written to fil
There was a problem hiding this comment.
Thank you, this is a good hint!
| params_to_skip_update=params_to_skip_update) | ||
|
|
||
|
|
||
| class MSOS104A(VisaInstrument): |
There was a problem hiding this comment.
I think it should have a more generic name the only difference that i can tell is the max frequency
Dominik-Vogel
changed the title
WilliamHPNielsen
suggested changes
Oct 10, 2017
WilliamHPNielsen
previously requested changes
Oct 10, 2017
|
Nice notebook! |
|
|
||
| def snapshot_base(self, update: bool=False) -> Dict: | ||
| params_to_skip_update = ['trace'] | ||
| super().snapshot_base(update=update, |
There was a problem hiding this comment.
This is missing a return statement
There was a problem hiding this comment.
Thanks! I fixed this.
|
|
||
| # compatitbility/setup | ||
| # change of names with acquire_ prefix | ||
| # add acquire_interpolate(1) to the setup |
There was a problem hiding this comment.
Should these lines still be her?
jenshnielsen
dismissed
WilliamHPNielsen’s stale review
This has now been done
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 18, 2017
Author: Dominik Vogel <30660470+Dominik-Vogel@users.noreply.github.com>
driver/Keysight Infiniium oscilloscope (as e.g. MSOS104A) (#766)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the driver for the Keysight Infiniium oscilloscopes. It has been developed for the MSOS104A. So far it features all the basic commands, including:
To get started please refer to the jupyter tutorial for this driver, supplied along with this PR.
fixes #701
The driver development has been simultaneously started by Steven Waddy. In the first commit I merged the two drivers.