Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver/Mini-Circuits #814

Merged
merged 15 commits into from
Dec 5, 2017
Merged

Driver/Mini-Circuits #814

merged 15 commits into from
Dec 5, 2017

Conversation

StevenWaddy
Copy link
Contributor

@StevenWaddy StevenWaddy commented Oct 25, 2017

@johnhornibrook
Copy link
Contributor

Hi, I use these drivers in the lab, and have no problems with either the code or the functionality.

@Dominik-Vogel
Copy link
Contributor

Thanks @StevenWaddy!
I briefly looked at the datasheet of the RC-1SP4T and it looks like one can set all the four switches individually. It is probably not relevant for your application, but I think that the feature of connecting the COM signal to e.g. outputs 1 and 2 might be wished for in the future. Because implementing this new feature would slightly break the interface of the driver and would make it inconvenient to upgrade, and on the otherhand implementing it straight away is probably not very time intensive.
Would you have the time to implement the RC-1SP4T analogously to the RC4SPDT with channels? Or alternatively one could use a bitmask...

@Dominik-Vogel
Copy link
Contributor

Looking at the programming guide it seems to me, that it would be a good idea to unify the two drivers. At a first glance it looks like we can use the RC4SPDT driver for both the RC4SPDT and the RC-1SP4T without any changes

channels added to make the commands the same across both drivers
with a minor modification the RC1SP4T driver could be used for the RC2SP4T
should work for the:
* RC-1SP4T-A12
* RC-1SP4T-A18
* RC-2SP4T-A12
* RC-2SP4T-A18
@StevenWaddy
Copy link
Contributor Author

The drivers should work for:
*RC-1SP4T
*RC-2SP4T
*RC-1SPDT
*RC-2SPDT
*RC-3SPDT
*RC-4SPDT
*RC-8SPDT
for both the -A12 and A18 versions
but has only been tested on the RC-1SP4T-A18 and RC-4SPDT-A18

@Dominik-Vogel , both drivers have now channels and the same interface.

The RC-xSP4T switches can only be switched between common and open or one of 1,2,3 or 4.
It is not possible to connect multiple outputs to the common or to each other the instrument
will ignore you if you try and it would not be possible to maintain Z=50Ohm if you did.
[pg 96 of the programming manual]

The RC-xSPDT only between common and 1 or 2

@johnhornibrook do you want to double check the drivers still work.

Copy link
Contributor

@Dominik-Vogel Dominik-Vogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @StevenWaddy, the channelized verion is beautiful! Sorry for the delay

@Dominik-Vogel
Copy link
Contributor

@johnhornibrook do you have an update of the status of the driver? does it still work, so that I can merge it?

@Dominik-Vogel
Copy link
Contributor

@johnhornibrook tested the driver and it still works, so that it is ready to merge.

@Dominik-Vogel Dominik-Vogel merged commit f595e74 into microsoft:master Dec 5, 2017
giulioungaretti pushed a commit that referenced this pull request Dec 5, 2017
Author: StevenWaddy <steven.waddy@sydney.edu.au>

    Driver/Mini-Circuits RC-xSP4T &  RC-1SP4T ethernet rf-switches (#814)
@jenshnielsen
Copy link
Collaborator

@Dominik-Vogel remember to close any issue in stationQ

giulioungaretti pushed a commit that referenced this pull request Dec 6, 2017
Author: StevenWaddy <steven.waddy@sydney.edu.au>

    Driver/Mini-Circuits RC-xSP4T &  RC-1SP4T ethernet rf-switches (#814)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants