Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver for Cryogenic sms120c #819

Merged
merged 20 commits into from
Nov 30, 2017
Merged

Driver for Cryogenic sms120c #819

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7eec74d
added driver for cryogenicSMS120C
layeoh Oct 26, 2017
e5154f2
autopep
layeoh Oct 26, 2017
ba39a27
merge from commit to up branch
eendebakpt Oct 29, 2017
fe99020
autopep
eendebakpt Oct 29, 2017
2b273b7
autopep (aggressive)
eendebakpt Oct 29, 2017
65361f9
remove unused Anything
eendebakpt Oct 29, 2017
392c333
fix unused key, value pairs
eendebakpt Oct 29, 2017
aed103c
Tested style changes with PS. Additional checks for polarity switch.
layeoh Oct 30, 2017
2b803ca
CryogenicSMS120C.py
layeoh Oct 31, 2017
94da171
Basic persistent mode detection and functionality completed.
layeoh Nov 15, 2017
524f2ab
Merge branch 'master' into feat/crygenicSMS120c
layeoh Nov 15, 2017
e56e219
update to sms120c
layeoh Nov 17, 2017
440a453
Merge branch 'feat/crygenicSMS120c' of https://github.com/Vandersypen…
layeoh Nov 17, 2017
ab882eb
autopep
eendebakpt Nov 19, 2017
f46357f
Updated print statements to log.info, update2
layeoh Nov 17, 2017
388698c
autopep
Nov 21, 2017
7901324
updates to driver
layeoh Nov 28, 2017
5da75d6
Removed logging level from driver
layeoh Nov 28, 2017
d8fbcbb
cleanup code
layeoh Nov 28, 2017
30e1a50
Merge branch 'master' into feat/crygenicSMS120c
WilliamHPNielsen Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
134 changes: 99 additions & 35 deletions qcodes/instrument_drivers/cryogenic/CryogenicSMS120C.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ def __init__(self, name, address, coil_constant=0.113375, current_rating=105.84,
idn = self.IDN.get()
print(idn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled by the connect_message method of the instrument. Unless the IDN response is too non-standard.


self._persistentField = 0 # temp code stub
self._coil_constant = coil_constant
self._current_rating = current_rating
self._current_ramp_limit = current_ramp_limit
Expand Down Expand Up @@ -104,8 +105,13 @@ def __init__(self, name, address, coil_constant=0.113375, current_rating=105.84,

self.add_parameter('persistentMode',
get_cmd=self._get_persistentMode,
set_cmd=self._set_persistentMode,
val_mapping={False: 0, True: 1})

self.add_parameter(name='persistentField',
get_cmd=self._get_persistentField,
vals=Numbers(self._persistentField))

self.add_parameter(name='field',
get_cmd=self._get_field,
set_cmd=self._set_field,
Expand Down Expand Up @@ -144,8 +150,8 @@ def query(self, msg):
separate regexp to parse unique/variable instrument message structures.

Returns:
key
value
key : unused
value : parsed value extracted from output message
"""
value = self.ask(msg)
m = re.match(r'((\S{8})\s)+(([^:]+)(:([^:]+))?)', value)
Expand Down Expand Up @@ -184,17 +190,39 @@ def _get_persistentMode(self):
_, value = self.query('HEATER')
field = self._get_field()
# check for switch heater OFF, and non-zero current
if 'OFF' in value and (field != 0):
if 'OFF' in value and abs(field <= 0.007):
persistentField = self._get_persistentField()
units = self._get_unit()
if units == 1:
print("Magnet in persistent mode, at a field of %f T" % field)
print("Magnet in persistent mode, at a field of %f T" %
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This print call (and many more below in the driver) should be converted to logging calls with the appropriate level.

persistentField)
elif units == 0:
print("Magnet in persistent mode, at a field of %f A" % field)
persistent_Mode = True
print("Magnet in persistent mode, at a field of %f A" %
persistentField)
persistentMode = True
else:
print("Magnet not persistent.")
persistent_Mode = False
return persistent_Mode
persistentMode = False
return persistentMode

# get units, returns a boolean integer - Tesla (1) or Amps(0)
def _get_persistentField(self):
# read persistent field from controller
BLeads = self._get_field()
if (self._get_switchHeater() == 1):
print("Switch heater ON, magnet not in persistent mode.")
persistentField = 0
elif (self._get_switchHeater() == 0) and (abs(BLeads) > 0.007):
print("Switch heater OFF, but current is still in present in leads - not in persistent mode. Leads at: %f" % BLeads)
perString = self.ask('GET PER')
m = re.match(r'((\S{8})\s)+([^:]+)', perString)
persistentField = float(m[2])
else:
perString = self.ask('GET PER')
# handles a different string return format
m = re.match(r'((\S{8})\s)+([^:]+)', perString)
persistentField = float(m[2])
return persistentField

def _get_unit(self): # get units, returns a boolean integer - Tesla (1) or Amps(0)
_, value = self.query('TESLA')
Expand Down Expand Up @@ -298,32 +326,79 @@ def _set_maxField(self, val): # Set the maximum field (in Amps or Tesla)

def _set_switchHeater(self, val): # Turn heater ON(1) or OFF(0)
if self._get_rampStatus() == 1:
log.error('Cannot switch heater during a ramp, first pause the ramp.')
log.error(
'Cannot switch heater during a ramp, first pause the controller.')
else:
# Switch ON, if currently OFF
if val == 1 and (self._get_switchHeater() == False):
strHeaterStatus = self.ask('HEATER %d' % val)
switchHeater = 1
print('Waiting 30s for switch heater to warm up.')
time.sleep(30) # wait for magnet to settle after switch
# Switch OFF, if currently ON
elif val == 0 and (self._get_switchHeater() == True):
strHeaterStatus = self.ask('HEATER %d' % val)
switchHeater = 0
if self._get_field != 0: # condition for persistent mode
self.persistent_mode = 1
print('Waiting 60s for switch heater to cool.')
# wait for magnet to settle into persistent mode after
# switch
time.sleep(60)
else:
print('Waiting 30s for switch heater to cool.')
time.sleep(30) # wait for magnet to settle after switch
else: # assume no change to current switch heater state
strHeaterStatus = self.ask('HEATER %d' % val)
log.info(strHeaterStatus)
return switchHeater

# Move into persiostent mode (1) or out of persiatet mode(0)
def _set_persistentMode(self, val):
if self._get_rampStatus() == 0: # Check magnet on HOLD
currField = self._get_field()
print("Leads now at %f ." % currField)
# Enter persistent mode from non-persistent
if val == 1:
if self._get_persistentMode() == False and (self._get_switchHeater() == True):
print('Moving into persistent mode:')
switchHeater = 0
strHeaterStatus = self.ask('HEATER %d' % switchHeater)
print(strHeaterStatus)
print('Waiting 60s for switch heater to cool down.')
time.sleep(60)
print('Ramping down magnet leads...')
self._set_field(0)
while True:
if self._get_rampStatus() == 0:
print('Leads at zero.')
persistentMode = 1
persistentField = self._get_persistentField()
print(
'Magnet is in persistent mode at Field = %f.' % persistentField)
break
time.sleep(5) # check every 5 seconds
elif self._get_persistentMode() == True:
persistentMode = 1
persistentField = self._get_persistentField()
print('Already in persistent mode.')
# Exit persistent mode
elif val == 0:
persistentField = self._get_persistentField()
if self._get_persistentMode() == True and (self._get_switchHeater() == False):
print('Exiting persistent mode from a field of %f' %
persistentField)
switchHeater = 1
strHeaterStatus = self.ask('HEATER %d' % switchHeater)
print(strHeaterStatus)
print('Waiting 30s for switch heater to warm up.')
time.sleep(30)
print(
'Matching magnet lead current to persistent field of %f...' % persistentField)
self._set_field(persistentField)
while True:
if self._get_rampStatus() == 0:
persistentMode = 0
persistentField = 0
print('Magnet is non-persistent.')
break
time.sleep(5) # check every 5 seconds
elif self._get_persistentMode() == False:
print('Magnet already non-persistent.')
else:
log.warning(
'Cannot change (non-)persistent mode state, check magnet status.')
return persistentMode, persistentField

def _set_pauseRamp(self, val): # Pause magnet controller Pause=1, Unpause=0
self.ask('PAUSE %d' % val)

Expand Down Expand Up @@ -359,20 +434,11 @@ def _can_startRamping(self):
'Magnet quench detected - please check magnet status before ramping.')
return False
elif state == 1: # Ramping
if self._get_switchHeater() == 1:
print('Magnet currently ramping.')
return True
else:
log.error(
'Magnet in unusual state - ramping with switch heater off, please check magnet status before ramping.')
return False
print('Magnet currently ramping.')
return True
elif state == 0: # Holding
if (not self._get_persistentMode()):
print('Magnet currently holding.')
return True
else:
print('Magnet in persistent mode.')
return True
print('Magnet currently holding.')
return True
log.error(
'Could not ramp, magnet in state: {}'.format(state))
return False
Expand All @@ -391,8 +457,6 @@ def _set_field(self, val):
self._get_unit() == 0 and (val <= self._current_rating)):
# pause the controller if it is currently ramping
self._set_pauseRamp(1)
if self._get_switchHeater() == 0: # set switch heater if not already ON
self._set_switchHeater(1)
self.ask('SET MID %0.2f' % val) # Set target field
self._set_pauseRamp(0) # Unpause the controller
# Ramp magnet/field to MID (Note: Using standard write as read
Expand Down