Setting _VERSA_EEPROM_available to False by default #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
=======================================
Coverage 77.92% 77.92%
=======================================
Files 37 37
Lines 5236 5236
=======================================
Hits 4080 4080
Misses 1156 1156 |
|
This has been tested and it works, for the test station (T1/T4). @jenshnielsen @WilliamHPNielsen @sohailc could anyone merge it? |
jenshnielsen
approved these changes
Feb 6, 2018
giulioungaretti
pushed a commit
that referenced
this pull request
Feb 6, 2018
Author: Dominik Vogel <30660470+Dominik-Vogel@users.noreply.github.com>
Setting _VERSA_EEPROM_available to False by default (#964)
giulioungaretti
pushed a commit
that referenced
this pull request
Feb 6, 2018
Author: Dominik Vogel <30660470+Dominik-Vogel@users.noreply.github.com>
Setting _VERSA_EEPROM_available to False by default (#964)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Decadac driver does not specify the value of _VERSA_EEPROM_available by default. It is only set to false if the feature is unavailable but never gets set to True. In this PR I set it to False by default instead of inserting the probably missing assignment of True, in order to prevent inserting a so far untested and also not missed feature.