Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver/Tektronix AWG5208 #977

Merged
merged 12 commits into from
Feb 27, 2018
Merged

Driver/Tektronix AWG5208 #977

merged 12 commits into from
Feb 27, 2018

Conversation

WilliamHPNielsen
Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen commented Feb 21, 2018

Changes proposed in this pull request:

  • Expand the AWG70000A parent class to accomodate for 5208's
  • Add a 5208 driver

Note that we have an AWG5200 driver that subclasses the 5014 driver. This file should probably be deleted, as the software is very different on those two AWGs, and noone seems to be using that driver (@peendebak, do you confirm/agree?).

Work items:

  • PyVISA tests
  • Tests with the instrument

@sohailc @jenshnielsen

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #977 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage    78.6%   78.62%   +0.01%     
==========================================
  Files          45       45              
  Lines        6423     6423              
==========================================
+ Hits         5049     5050       +1     
+ Misses       1374     1373       -1

@WilliamHPNielsen
Copy link
Contributor Author

I would call this a working driver. @sohailc, what do you say?

@sohailc
Copy link
Member

sohailc commented Feb 23, 2018 via email

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to land. We can always add more features as we go. Only question is if we should deprecate the other driver now?

@WilliamHPNielsen
Copy link
Contributor Author

@jenshnielsen Let's deprecate it now. Or even remove it. We have intelligence saying that no one is using that driver.

@WilliamHPNielsen WilliamHPNielsen merged commit f167b33 into master Feb 27, 2018
giulioungaretti pushed a commit that referenced this pull request Feb 27, 2018
Author: William H.P. Nielsen <whpn@mailbox.org>

    Driver/Tektronix AWG5208 (#977)
@astafan8 astafan8 deleted the driver/TektronixAWG5208 branch December 4, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants