This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Update Advanced Estimation RE notebook to use azure_quantum API #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katymccl
reviewed
Aug 23, 2023
| "items = [{\"arguments\": [{\"name\": \"bitwidth\", \"value\": bitwidth, \"type\": \"Int\"}], **params} for (_, params) in target_params for bitwidth in bitwidths]\n", | ||
| "params = estimator.make_params(num_items=len(bitwidths) * len(target_params))\n", | ||
| "\n", | ||
| "for idx, (_, target_param) in enumerate(target_params):\n", |
There was a problem hiding this comment.
nit: change to index or i
katymccl
approved these changes
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
azure_quantumAPI is recommended to use over the IQ# API, since it is general for all input. In this PR, we change the advanced estimation notebook to use this API.