-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UnitaryPatterns] Workbook Solutions Complete #377
Conversation
Could you please unentangle this PR from the MultiQubitGates change in #375? Looks like you've branched this PR off that branch, and I'd prefer to review them separately, since they are independent changes. |
Apologies. I didnt realise those changes got entangled with this Branch. I have reset the file to MultiQubitGates.ipynb as it is on the latest commit in Microsoft/QuantumKatas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a round of cleanup - it looks like a lot of changes but in fact it's mostly spelling, capitalization and phrasings. The larger changes are:
- I added an image for a decrement circuit (I think it's more descriptive than just saying "a cascade of gates")
- I removed applications of I gates - it's not necessary, and I'd rather not teach the learner to apply identity when it's not necessary, this causes all kinds of weird code patterns later :-)
- In task 15 T_N(i) can be formatted a lot neater using
\ddots
command, and I think there were typos in spelling out T_2(1) and T_2(2) - the rows of 2x2 blocks were shifted by one element.
Looks great, and it's a very serious amount of work - it took me a a fair amount of time to go though it all (admittedly, mostly because I'm not very familiar with the last couple of tasks).
Thank you!
Looking at your initial comment, what do you mean by "Encapsulated Functions" and what kinds of errors were they causing? |
While writing solutions for Task 13, I used the helper |
Added Workbook_UnitaryPatterns and cross-linked it with UnitaryPatterns as discussed in Comment in Issue #208.
The Workbook Solutions for all Tasks from 1 to 15 have been done.
I didn't notice the solutions in ReferenceImplementation.qs hence I have implemented my own solutions for the most part. They are mostly similar to the ReferenceImplementations.
For Task 13 - Removed Encapsulated Functions since that was causing errors in the Kernel Cell
For Task 14 - The Solution is longer but I believe it is easier to comprehend that the reference solution.
For Task 15 - I have simplified the solution. The reference solution didn't take advantage of the fact that both indices are always consecutive.
All checks are now passing.