[SingleQubitGates] Workbook Solutions Complete #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
jainvasu631
force-pushed
the
SingleQubitWorkbook
branch
from
66491ff
to
f50e754
Compare
tcNickolas
approved these changes
Jul 5, 2020
There was a problem hiding this comment.
Looks great! I did a bit of cleanup for some phrasings (for example, we try not to say things "this is trivial" - it sort of is, but if a person landed in a workbook for the very first exercise, they're already struggling with it, and don't need any discouragement). The biggest change I did was to simplify the solution to exercise 7 - using Ry gate is a lot easier than Rx + S, and we want to teach the learner Ry for the later superposition tasks.
I'll merge once the CI build passes. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Workbook_SingleQubitGates and cross-linked it with SingleQubitGates as discussed in Comment in Issue #208.