Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

API review June 2022 #596

Merged
merged 5 commits into from
Jul 7, 2022
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions Design/meetings/2022/api-design-2022-06.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Q# API Design Discussions / June 2022

Reviewers (in order by username): @tcNickolas, @cgranade

## Agenda

- https://github.com/microsoft/QuantumLibraries/issues/593
- https://github.com/microsoft/QuantumLibraries/issues/594
- https://github.com/microsoft/QuantumLibraries/issues/595

## Discussion

### Comparison operations

**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/593

**Reviews**:
msoeken marked this conversation as resolved.
Show resolved Hide resolved
msoeken marked this conversation as resolved.
Show resolved Hide resolved
- @cgranade, *comment*: Does the `action` input to `ApplyControlledOnLessThanFxP` need to be adjointable? Should there be a separate `Adj` variant? We may also want to describe quickly how this proposal works with the outstanding proposal for numerics refactoring all-up (https://github.com/microsoft/QuantumLibraries/issues/337).
* @tcNickolas, *approve*, left a comment
> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue.

**Consensus**:
msoeken marked this conversation as resolved.
Show resolved Hide resolved

---

### Functions for smallest and largest representable fixed point

**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/594

**Reviews**: @cgranade, *approve*, same comment as above (https://github.com/microsoft/QuantumLibraries/issues/337).
* @tcNickolas, *approve*, left a comment
> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue.

**Consensus**:
msoeken marked this conversation as resolved.
Show resolved Hide resolved

---

### Conversion functions for signed integers

**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/595

**Reviews**:
msoeken marked this conversation as resolved.
Show resolved Hide resolved
msoeken marked this conversation as resolved.
Show resolved Hide resolved
* @cgranade: *comment*. We should coordinate this with the Q# language discussion around bit vectors in general. @swernli and @bettinaheim in particular may want to provide input here.
* @tcNickolas, *approve*, left a comment
> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue.

**Consensus**:
msoeken marked this conversation as resolved.
Show resolved Hide resolved