Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

IInteractiveWindow.WriteErrorLine can throw NRE when VS is closing #2637

Closed
AlexanderSher opened this issue Nov 3, 2016 · 7 comments
Closed

IInteractiveWindow.WriteErrorLine can throw NRE when VS is closing #2637

AlexanderSher opened this issue Nov 3, 2016 · 7 comments
Assignees
@AlexanderSher
Labels
Dev15 status:external type:bug
Milestone
Wave 2

Comments

@AlexanderSher
Copy link
Contributor

Not sure what we can do about it other than catching exception.
@MikhailArkhipov
Copy link
Contributor

Just catch it for now

@MikhailArkhipov MikhailArkhipov added this to the Sprint 8 milestone Nov 4, 2016
@MikhailArkhipov MikhailArkhipov modified the milestones: Sprint 9, Sprint 8 Nov 17, 2016
@MikhailArkhipov
Copy link
Contributor

Now that I am getting dotnet/interactive-window#23 through, do you want me to fix this in the IW?

@AlexanderSher
Copy link
Contributor Author

Yes, that would be great.
Basically, we need to check Dispatcher.HasShutdownStarted inside InteractiveWindow.UIThread methods

@MikhailArkhipov
Copy link
Contributor

Basically just do nothing if it is shutting down?

@AlexanderSher
Copy link
Contributor Author

Yes

@MikhailArkhipov MikhailArkhipov modified the milestones: Wave 2, Sprint 9 Dec 14, 2016
@MikhailArkhipov
Copy link
Contributor

I'd talk to @tmat

@MikhailArkhipov MikhailArkhipov mentioned this issue Jan 10, 2017
Open
@MikhailArkhipov
Copy link
Contributor

dotnet/interactive-window#32

@huguesv huguesv mentioned this issue Jul 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AlexanderSher AlexanderSher

Labels
Dev15 status:external type:bug
Projects
None yet
Milestone
Wave 2
Development

No branches or pull requests
2 participants
@AlexanderSher @MikhailArkhipov