Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE DateTimeV2] Support for time expression [minutes] nach/vor [hour] #3081

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

andrew-gradinari
Copy link
Contributor

Adding support for German time expressions such as "10 nach 3" and "zehn nach drei" (ten past three), as well as "5 vor 4" and "fünf vor vier" (five to four).

For reference:

tellarin and others added 22 commits March 25, 2022 16:35
…n for Units (microsoft#2877) (microsoft#2879)

- Support informal degrees in PT and ES (microsoft#2877);

- Fix issue in generation of Spanish unit resources;

- Re-generate all resources across platforms.
…icrosoft#2878)

* Enabling SpanishMexican culture in Number/Unit/DateTimveV2

* Update Spanish number specs according to review

Co-authored-by: Colm Dillon <cdillon@ip-192-168-0-108.ec2.internal>
* Add Portuguese DateTime support in Python

* Update Specs with Python changes

* Fix Number import issue

* Update specs according to build and review

* Remove empty NotSupported fields from specs
microsoft#2863) (microsoft#2892)

Co-authored-by: aitelint <Fabrizio.Sorba@telusinternational.com>
…eTimeRanges (microsoft#2894)

* Workaround for TimexProperty.ToString() to not crash on DateTimeRanges 

* Add TODO for fixing the TimexProperty date range representation properly according to review
Fetch microsoft/Recognizers-Text upstream changes
[NLU-2858] Fetch upstream changes from microsoft:master -> purecloudlabs:master
Merge MS Recognizers into master
Bringing Pureclould Labs master up to-date with Microsoft master
Update fork with MS recognizers latest
@andrew-gradinari andrew-gradinari changed the title [DE DateTimeV2] Support for time expressions: [minutes] nach [hour] and [minutes] vor [hour] [DE DateTimeV2] Support for time expressions: [minutes] nach/vor [hour] Mar 3, 2023
@andrew-gradinari andrew-gradinari changed the title [DE DateTimeV2] Support for time expressions: [minutes] nach/vor [hour] [DE DateTimeV2] Support for time expression [minutes] nach/vor [hour] Mar 3, 2023
@andrew-gradinari
Copy link
Contributor Author

The AppVeyor build failed due to:

Build execution time has reached the maximum allowed time for your plan (60 minutes).

Will try again.

@andrew-gradinari andrew-gradinari marked this pull request as ready for review March 3, 2023 17:32
@andrew-gradinari
Copy link
Contributor Author

@tellarin the issue with the tests has been fixed. Could you please take a look?

@tellarin tellarin closed this Mar 16, 2023
@tellarin tellarin reopened this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants