Add C# wrapper #60
Merged
Add C# wrapper #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlphardWang
reviewed
Jun 17, 2019
AnnService/inc/Core/SearchQuery.h
Outdated
| std::unique_ptr<BasicResult[]> m_results; | ||
|
|
||
| std::unique_ptr<ByteArray[]> m_metadatas; | ||
| std::shared_ptr<BasicResult> m_results; |
There was a problem hiding this comment.
if you do need a shared_array, maybe it is better to convert ByteArray into a template
AlphardWang
reviewed
Jun 17, 2019
Wrappers/inc/CsharpCommon.i
Outdated
| struct WrapperArray | ||
| { | ||
| void * _data; | ||
| size_t _size; |
There was a problem hiding this comment.
please always use space instead of tab
AlphardWang
reviewed
Jun 18, 2019
AnnService/inc/Core/SearchQuery.h
Outdated
| { | ||
| std::copy(p_other.m_metadatas.get(), p_other.m_metadatas.get() + m_resultNum, m_metadatas.get()); | ||
| } | ||
| std::memcpy(m_results.Data(), p_other.m_results.Data(), sizeof(BasicResult) * m_resultNum); |
There was a problem hiding this comment.
BasicResult is not POD, please use std::copy instead of memcpy
AlphardWang
approved these changes
Jun 19, 2019
MaggieQi
added a commit
to MaggieQi/SPTAG
that referenced
this pull request
Jun 26, 2019
Add C# wrapper (microsoft#60)
t-phada
pushed a commit
to t-phada/SPTAG
that referenced
this pull request
Aug 19, 2020
* remove dup code * Update Readme.md * Fix DataSet GNU compile fail bug * fix GNU Windows align alloc bugs * add copyright in each file * fix copy right in dataset * change kdt distance judgement * change code structure and add more wrappers * Update docs * fix search result * change IndexBuilder to support binary input data * temp remove java related projects * remove javaclient and javacore from the windows build * Fix SetData issue * Add vector record count and dimension for reuse and debug * change default parameter definition * add uint8 support * small fix for cosine distance of uint8 * fix AVX distance calculation epu8 * update readme * Update DistanceUtils.h * fix python wrapper cannot load larger than 4G memory error * try to add C# wrapper * fix owner of C# wrapper * add C# cmake support * fix byte array copy * fix tab to space * Try to make shared_ptr<T> as Array template * fix copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.