change code structure and try to clean wrapper definitions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlphardWang
reviewed
Mar 15, 2019
| @@ -101,13 +101,27 @@ ByteArray::Data() const | |||
| } | |||
|
|
|||
|
|
|||
| void | |||
| ByteArray::SetData(std::uint8_t* p_array) | |||
There was a problem hiding this comment.
Suggest not to set members separately, which may mess up the data.
AlphardWang
approved these changes
May 7, 2019
MaggieQi
referenced
this pull request
in MaggieQi/SPTAG
May 13, 2019
change code structure and try to clean wrapper definitions (#8)
t-phada
pushed a commit
to t-phada/SPTAG
that referenced
this pull request
Aug 19, 2020
* remove dup code * Update Readme.md * Fix DataSet GNU compile fail bug * fix GNU Windows align alloc bugs * add copyright in each file * fix copy right in dataset * change kdt distance judgement * change code structure and add more wrappers * Update docs * fix search result * change IndexBuilder to support binary input data * temp remove java related projects * remove javaclient and javacore from the windows build * Fix SetData issue
PhilipBAdams
added a commit
that referenced
this pull request
Jun 9, 2022
* MVP version of Data compress (#1) * Support delta-encoding (#2) * support config of compress level (#3) * integrate zstd with cmake (#4) * Bug Fix: wrong listPageCount when listTotalBytes % pageSize==0 (#5) * train & share dictionary (#6) * rearrange posting list (#7) * config minDictTraingBufferSize and dictBufferCapacity (#8) * cmake with local installed zstd (#9) * refine visual studio config (#10) * parallel for get compressed size (#11) * fix check truth bug (#12) * change zstd branch (#13) * remove verbose log in truth analysis; refine dockerfile * check rvalue in Compressor.h * resolve back compatibility by add a search option: WithDataCompressionFeatures * remove redundant configs, change head info format only when compression enabled * reuse buffer when decompression * remove exit(1) from search index * bug fix: reuse compression buffer in workspace # with '#' will be ignored, and an empty message aborts the commit. * code refine * optimize mem usage * replace vcpkg zstd with nuget * config issue * fix solution build issue Co-authored-by: Philip Adams <35666630+PhilipBAdams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.