Fix #94 and remove compiler bug workarounds. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Properly comment "Tukey's ninther". * Remove workarounds for VSO-946746. VSO-946746 "conditional explicit(bool) doesn't work with /clr:pure" was fixed on 2019-07-23, and should be available in VS 2019 16.4 Preview 1. * Remove workarounds for VSO-433486. VSO-433486 "_Count / 2 inside while (0 < _Count) loop is not transformed into a simple shift" was fixed on 2019-08-27 and should be available in VS 2019 16.4 Preview 2. Some shifts are still necessary, and are now commented. * This mirrors a Microsoft-internal PR: https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/207988
CaseyCarter
approved these changes
Oct 15, 2019
fengjixuchui
added a commit
to fengjixuchui/STL
that referenced
this pull request
Oct 16, 2019
Fix microsoft#94 and remove compiler bug workarounds. (microsoft#175)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Properly comment "Tukey's ninther".
Remove workarounds for VSO-946746.
VSO-946746 "conditional explicit(bool) doesn't work with /clr:pure"
was fixed on 2019-07-23, and should be available in
VS 2019 16.4 Preview 1.
VSO-433486 "_Count / 2 inside while (0 < _Count) loop is not
transformed into a simple shift" was fixed on 2019-08-27
and should be available in VS 2019 16.4 Preview 2.
Some shifts are still necessary, and are now commented.
https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/207988
Checklist
If you're unsure about a box, leave it unchecked. A maintainer will help you.
If a box isn't applicable, add an explanation in bold.
For example: (N/A: this is a bugfix, not a feature)
community PRs will be delayed until the test and CI systems are online.
C++ Working Draft. (N/A, no features)
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 .
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.