Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port STL portion of MSVC-PR-311353 #1759

Merged
merged 1 commit into from Mar 19, 2021
Merged

Port STL portion of MSVC-PR-311353 #1759

merged 1 commit into from Mar 19, 2021

Conversation

CaseyCarter
Copy link
Member

DevCom-952724 has been fixed internally (woot) and this test needs to tolerate both buggy and non-buggy compilers.

@CaseyCarter CaseyCarter added the enhancement Something can be improved label Mar 18, 2021
@CaseyCarter CaseyCarter requested a review from a team as a code owner March 18, 2021 17:23
@CaseyCarter CaseyCarter added this to Initial Review in Code Reviews via automation Mar 18, 2021
miscco
miscco approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the short feedback loop that MSVC_INTERNAL_TESTING gives

@CaseyCarter CaseyCarter added test Related to test code and removed enhancement Something can be improved labels Mar 18, 2021
@CaseyCarter
Copy link
Member Author

I really like the short feedback loop that MSVC_INTERNAL_TESTING gives

Yes! MSVC_INTERNAL_TESTING is the best thing to happen to our testing since _STL_INTERNAL_CHECK. I think there have been at least three temporary one-off feature-test macros added to the compiler and then later removed that all could have been avoided with MSVC_INTERNAL_TESTING.

@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Mar 19, 2021
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Mar 19, 2021
@StephanTLavavej StephanTLavavej merged commit 7570481 into microsoft:main Mar 19, 2021
Code Reviews automation moved this from Ready To Merge to Done Mar 19, 2021
@StephanTLavavej
Copy link
Member

Thanks for keeping the repos in sync! 🐱 🐱

@CaseyCarter CaseyCarter deleted the port branch March 19, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@MahmoudGSaleh MahmoudGSaleh MahmoudGSaleh approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CaseyCarter @StephanTLavavej @miscco @MahmoudGSaleh