Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize more types #1856

Merged
merged 5 commits into from Aug 5, 2021
Merged

Visualize more types #1856

merged 5 commits into from Aug 5, 2021

Conversation

AdamBucior
Copy link
Contributor

image

@AdamBucior AdamBucior requested a review from a team as a code owner April 18, 2021 11:40
@StephanTLavavej StephanTLavavej added the visualizer How the VS debugger displays STL types label Apr 18, 2021
@StephanTLavavej StephanTLavavej added this to Initial Review in Code Reviews via automation Apr 18, 2021
Code Reviews automation moved this from Initial Review to Work In Progress Apr 20, 2021
AnjuDel
AnjuDel suggested changes Apr 20, 2021
View reviewed changes
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej moved this from Work In Progress to Initial Review in Code Reviews May 12, 2021
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Jun 16, 2021
Code Reviews automation moved this from Final Review to Work In Progress Jul 21, 2021
CaseyCarter
CaseyCarter requested changes Jul 21, 2021
View reviewed changes
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Show resolved Hide resolved
@AdamBucior @CaseyCarter
Apply suggestions from code review
b5e1858 
Co-authored-by: Casey Carter <cartec69@gmail.com>
@CaseyCarter CaseyCarter moved this from Work In Progress to Final Review in Code Reviews Jul 21, 2021
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Jul 21, 2021
@CaseyCarter CaseyCarter assigned AnjuDel and unassigned CaseyCarter and AnjuDel Jul 21, 2021
@StephanTLavavej
Copy link
Member

@AnjuDel has created MSVC-PR-341980 and VS-PR-341981.

@AnjuDel AnjuDel merged commit 5d94b31 into microsoft:main Aug 5, 2021
Code Reviews automation moved this from Ready To Merge to Done Aug 5, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing all of these visualizers! 🥽 😻 🎉

@AdamBucior AdamBucior deleted the visualize-more-types branch August 6, 2021 07:46
@mwinterb mwinterb mentioned this pull request Sep 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej left review comments

@AnjuDel AnjuDel AnjuDel approved these changes

Assignees

@AnjuDel AnjuDel

Labels
visualizer How the VS debugger displays STL types
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdamBucior @StephanTLavavej @CaseyCarter @AnjuDel