Fix race condition in iterator debug machinery #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
requested changes
Jul 14, 2021
Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com> Co-authored-by: Casey Carter <cacarter@microsoft.com>
miscco
commented
Jul 15, 2021
stl/inc/xmemory
Outdated
Comment on lines
1131
to
1145
| _Orphan_me_v2(); | ||
| #ifdef __cpp_lib_constexpr_dynamic_alloc | ||
| if (_STD is_constant_evaluated()) { | ||
| _Orphan_me_unlocked(); | ||
| } else | ||
| #endif // __cpp_lib_constexpr_dynamic_alloc | ||
| { | ||
| _Orphan_me_locked(); | ||
| } |
There was a problem hiding this comment.
Note this is a little bit of unrelated debug performance improvement, but I believe we should try to minimize the effect on debug performance
|
It seems we still have some race condition somewhere |
|
Oh it turns out the bug is with So I would change the test to only clear the container |
CaseyCarter
reviewed
Jul 15, 2021
CaseyCarter
requested changes
Jul 15, 2021
CaseyCarter
approved these changes
Jul 15, 2021
AdamBucior
reviewed
Jul 15, 2021
miscco
commented
Jul 18, 2021
Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>
CaseyCarter
approved these changes
Jul 19, 2021
StephanTLavavej
approved these changes
Jul 29, 2021
|
@CaseyCarter @miscco @mnatsuhara FYI, I've pushed a series of commits, some significant. |
|
I'm going to add this to the next batch of changes to merge - please notify me if any further commits are pushed. |
mnatsuhara
approved these changes
Jul 29, 2021
CaseyCarter
approved these changes
Jul 29, 2021
|
Thanks for fixing this high priority bug! 🪲 😸 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2058