Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1272R4 Byteswapping for fun&&nuf #2235

Merged
merged 12 commits into from
Oct 20, 2021
Merged

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Oct 4, 2021

The paper misses __cpp_lib_byteswap value, picked the current date as a speculation

Fixes #2247.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner October 4, 2021 18:14
stl/inc/bit Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter added the cxx23 C++23 feature label Oct 4, 2021
@CaseyCarter CaseyCarter added this to Initial Review in Code Reviews via automation Oct 4, 2021
stl/inc/bit Outdated Show resolved Hide resolved
Code Reviews automation moved this from Initial Review to Work In Progress Oct 6, 2021
tests/std/tests/P1272R4_byteswap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1272R4_byteswap/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1272R4_byteswap/test.cpp Show resolved Hide resolved
@CaseyCarter CaseyCarter moved this from Work In Progress to Initial Review in Code Reviews Oct 6, 2021
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Oct 6, 2021
@StephanTLavavej StephanTLavavej self-assigned this Oct 13, 2021
stl/inc/bit Show resolved Hide resolved
stl/inc/bit Outdated Show resolved Hide resolved
tests/std/tests/P1272R4_byteswap/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Oct 19, 2021
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Oct 19, 2021
@StephanTLavavej
Copy link
Member

@AlexGuteniev @CaseyCarter Looks good, thanks. I pushed a couple of tiny changes - please meow if you disagree!

@StephanTLavavej StephanTLavavej self-assigned this Oct 19, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a6718c2 into microsoft:main Oct 20, 2021
Code Reviews automation moved this from Ready To Merge to Done Oct 20, 2021
@StephanTLavavej
Copy link
Member

🚀 😻 🎉 !sknahT

@AlexGuteniev AlexGuteniev deleted the bswap branch October 20, 2021 10:29
AtariDreams pushed a commit to AtariDreams/STL that referenced this pull request Nov 4, 2021
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx23 C++23 feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

P1272R4 byteswap()
4 participants