Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3422: Issues of seed_seq's constructors #2260

Merged
merged 2 commits into from Oct 20, 2021
Merged

LWG-3422: Issues of seed_seq's constructors #2260

merged 2 commits into from Oct 20, 2021

Conversation

MattStephanson
Copy link
Contributor

Implements LWG-3422.

@MattStephanson MattStephanson requested a review from a team as a code owner October 6, 2021 04:23
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Oct 6, 2021
@CaseyCarter CaseyCarter added this to Initial Review in Code Reviews via automation Oct 6, 2021
@CaseyCarter CaseyCarter mentioned this pull request Oct 6, 2021
Closed
39 tasks
CaseyCarter
CaseyCarter reviewed Oct 6, 2021
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion - since I can't review code without calling out something - in addition to your and @AlexGuteniev's comments.

stl/inc/random Show resolved Hide resolved
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Oct 7, 2021
@StephanTLavavej StephanTLavavej self-assigned this Oct 13, 2021
@StephanTLavavej
Copy link
Member

Interestingly, <random> is mandated to include <initializer_list>, so I was unable to find any nitpicks with this PR. Perfect! 😹

@StephanTLavavej StephanTLavavej removed their assignment Oct 16, 2021
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Oct 16, 2021
@StephanTLavavej StephanTLavavej self-assigned this Oct 19, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ebd229f into microsoft:main Oct 20, 2021
Code Reviews automation moved this from Ready To Merge to Done Oct 20, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution! 🌱 😸 ✔️

AtariDreams pushed a commit to AtariDreams/STL that referenced this pull request Nov 4, 2021
@MattStephanson @AtariDreams
LWG-3422: Issues of seed_seq's constructors (microsoft#2260)
b57df52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@AlexGuteniev AlexGuteniev AlexGuteniev approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MattStephanson @StephanTLavavej @CaseyCarter @miscco @AlexGuteniev