New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't /LTCG CRT initializers #2314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After TryAcquireSRWLockExclusive
is impoerted statically due to Vista drop, the only way to observe the difference would be __crtGetSystemTimePreciseAsFileTime
, which affects system_clock::now()
granularity. I don't think we need a test for it.
I have manually verified the fix. // cl /EHsc /nologo /W4 /MD /Zi /Fdmeow.pdb meow.cpp
#include <cstdio>
#include <mutex>
using namespace std;
int main() {
mutex mut;
puts("BEFORE");
mut.lock();
puts("DURING");
mut.unlock();
puts("AFTER");
} Before this PR, stepping into
After this PR, it calls:
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks @AlexGuteniev for finding and @CaseyCarter for fixing this lurking bug! 🐞 🛠️ 😸 |
Fixes #2311
I verified the fix manually; open to suggestions for test coverage.