static_assert that container and allocator type parameters are object types
#2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e() &&` invalidates outer iterators Fixes microsoft#2401
…nd allocator Fixes microsoft#2408. This PR implements a message (or more, depending on structure) when you try to instantiate an object which has inherent contradicting type requirements (ex. "pointer to reference"). I tried not to be pedantic with the implementation, but I might've went wrong with that, thus I'm sorry if I did. Notes: I have noticed different order for implementing static asserts in containers, sometimes it's before required types and right after, if there is, friend classes, and sometimes, it's after required types and in different access modifiers (not like it changes anything, just a nitpick).
cristeigabriel
force-pushed
the
main
branch
3 times, most recently
from
10235a4
to
5cb35b1
Compare
miscco
reviewed
Dec 19, 2021
sam20908
reviewed
Dec 24, 2021
strega-nil-ms
changed the title
static_assert that container and allocator type parameters are not reference types
StephanTLavavej
added
the
decision needed
StephanTLavavej
removed
the
decision needed
|
Should we just |
|
Yeah, that's a good idea, modulo I'll review and revise this PR that we've neglected for far too long (sorry! 🙀). Updated title accordingly (yes, the title glosses over |
* Changed `unordered_multimap` which was originally overlooked * Varied the wording for container adaptors * For `map`, `multimap`, `unordered_map`, and `unordered_multimap`, checked both the keys and values * Added `!is_function_v<_Ty>` to `allocator` * Changed the checks outside `allocator` to `is_object_v<_Ty>` with matching messages
StephanTLavavej
changed the title
static_assert that container and allocator type parameters are not reference typesstatic_assert that container and allocator type parameters are object types
StephanTLavavej
approved these changes
Apr 10, 2023
|
Pushed:
|
strega-nil-ms
approved these changes
Apr 11, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving these diagnostics - and my apologies again for taking over a year to merge this! 🐌 🦥 🐢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2408.
This PR implements a message (or more, depending on structure) when you try to instantiate an object which has inherent contradicting type requirements (ex. "pointer to reference").
I tried not to be pedantic with the implementation, but I might've went wrong with that, thus I'm sorry if I did.
Notes: I have noticed different order for implementing static asserts in containers, sometimes it's before required types and right after, if there is, friend classes, and sometimes, it's after required types and in different access modifiers (not like it changes anything, just a nitpick).