Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untag dispatch _Directory_iterator #2478

Merged
merged 4 commits into from Mar 2, 2022
Merged

Untag dispatch _Directory_iterator #2478

merged 4 commits into from Mar 2, 2022

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Jan 15, 2022 •
edited by StephanTLavavej

Towards #189

@AlexGuteniev
Untag dispatch _Directory_iterator
cc64f39 
Towards microsoft#189
@miscco would suggest enum instead of bool, so doing it in advance
@AlexGuteniev AlexGuteniev requested a review from a team as a code owner January 15, 2022 14:55
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Jan 16, 2022
@StephanTLavavej StephanTLavavej added this to Initial Review in Code Reviews via automation Jan 16, 2022
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 18, 2022
@StephanTLavavej
Copy link
Member

While using an enum class would be more readable and more mistake-resistant, it would also break ABI (see my comment for a fully worked example), so I've pushed a change to undo that.

@CaseyCarter CaseyCarter self-assigned this Feb 23, 2022
@CaseyCarter CaseyCarter moved this from Final Review to Ready To Merge in Code Reviews Feb 24, 2022
@CaseyCarter CaseyCarter removed their assignment Feb 24, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 1, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 42caa91 into microsoft:main Mar 2, 2022
Code Reviews automation moved this from Ready To Merge to Done Mar 2, 2022
@StephanTLavavej
Copy link
Member

Thanks for modernizing this code! 😻 🎉 🌟

@AlexGuteniev AlexGuteniev deleted the untag_dispatch_dir_iterator branch March 2, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter