Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even rvalue empty_views are borrowed_ranges #2576

Merged
merged 1 commit into from Mar 19, 2022

Conversation

CaseyCarter
Copy link
Member

....which we somehow missed when implementing P1870R1 "forwarding-range<T> is too subtle".

....which we somehow missed when implementing P1870R1 "`forwarding-range<T>` is too subtle".
@CaseyCarter CaseyCarter added bug Something isn't working ranges C++20/23 ranges labels Feb 17, 2022
@CaseyCarter CaseyCarter added this to Initial Review in Code Reviews via automation Feb 17, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner February 17, 2022 07:38
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in Code Reviews Feb 18, 2022
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Mar 16, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 18, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 291e0ad into microsoft:main Mar 19, 2022
Code Reviews automation moved this from Ready To Merge to Done Mar 19, 2022
@StephanTLavavej
Copy link
Member

Thanks for finding and fixing this ranges bug! 🐞 😸 🎉

@CaseyCarter CaseyCarter deleted the empty_borrowed branch March 21, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ranges C++20/23 ranges
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants