Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_future's [[nodiscard("message")]] #3068

Merged
merged 4 commits into from
Sep 3, 2022

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner September 1, 2022 09:00
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
AlexGuteniev and others added 2 commits September 1, 2022 12:38
Co-authored-by: Jovibor <jovibor@users.noreply.github.com>
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Sep 1, 2022
@StephanTLavavej StephanTLavavej added this to Initial Review in Code Reviews via automation Sep 1, 2022
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter changed the title new future message Update get_future's [[nodiscard("message")]] Sep 1, 2022
@CaseyCarter CaseyCarter moved this from Initial Review to Final Review in Code Reviews Sep 2, 2022
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in Code Reviews Sep 2, 2022
@StephanTLavavej StephanTLavavej self-assigned this Sep 3, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0962491 into microsoft:main Sep 3, 2022
Code Reviews automation moved this from Ready To Merge to Done Sep 3, 2022
@StephanTLavavej
Copy link
Member

Thanks for clarifying this message! ✨ 😸 🎉

@AlexGuteniev AlexGuteniev deleted the dont_discard_future branch September 4, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants