<xlocale>: _Uglify non-conforming locale::c_str()
#3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add noexcept
frederick-vs-ja
changed the title
locale::c_str()<xlocale>: _Uglify non-conforming locale::c_str()
StephanTLavavej
approved these changes
Sep 8, 2022
|
This is old, so it has some potential to break real-world code, but let's try it. |
strega-nil-ms
approved these changes
Sep 12, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for noticing and fixing this ancient nonconformance! 😻 🦅 ✅ |
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add
noexceptto it. Fixes #3087.I hope the existing uses of this extension are sufficiently rare. The
noexceptdoesn't seem quite useful, since the_C_strmember (after change) is only called within potentially-throwing functions, but it may reduce compiler's unhappiness caused by C26440 under some conditions (reported in #3081).